Skip to content

Minor bug fixes#411

Merged
ppinchuk merged 14 commits intomainfrom
pp/minor_bug_fixes
Apr 22, 2026
Merged

Minor bug fixes#411
ppinchuk merged 14 commits intomainfrom
pp/minor_bug_fixes

Conversation

@ppinchuk
Copy link
Copy Markdown
Collaborator

Minor bug fixes and dependency updates

@ppinchuk ppinchuk added this to the Long-term plans milestone Apr 21, 2026
@ppinchuk ppinchuk self-assigned this Apr 21, 2026
Copilot AI review requested due to automatic review settings April 21, 2026 22:03
@ppinchuk ppinchuk requested a review from castelao as a code owner April 21, 2026 22:03
@ppinchuk ppinchuk added bugfix Fixed a known bug dependencies Issues/pull requests related to a dependency p-high Priority: high labels Apr 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Minor bug fixes and dependency updates, primarily focused on CSV encoding behavior and CLI/docs adjustments.

Changes:

  • Bump nlr-elm and adjust crawl4ai dependency handling/pinning.
  • Standardize CSV read/write encodings across finalize/threaded services and the water plugin.
  • Simplify CLI docs by switching Sphinx Click to render nested subcommands from the main compass entry.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pyproject.toml Updates dependency versions and removes crawl4ai from top-level deps while tightening Pixi ELM pin.
docs/source/dev/advanced_plugin_development.rst Updates example CSV export to include UTF-8 BOM encoding.
docs/source/_cli/compass.rst Switches Sphinx Click nesting to render full subcommand tree.
docs/source/_cli/compass process.rst Removes the dedicated compass process CLI doc page.
docs/source/_cli/cli.rst Updates CLI docs toctree to match the new nested Click output.
compass/utilities/finalize.py Reads ordinance CSVs with explicit UTF-8 and writes final outputs with UTF-8 BOM.
compass/services/threaded.py Writes per-jurisdiction ordinance CSVs with UTF-8 BOM.
compass/extraction/water/plugin.py Reads plugin CSVs with explicit UTF-8 and writes aggregated output with UTF-8 BOM.
compass/_cli/finalize.py Tweaks finalize CLI option help text wording.

Comment thread compass/_cli/finalize.py Outdated
Comment thread pyproject.toml
Comment thread compass/utilities/finalize.py Outdated
Comment thread compass/services/threaded.py
Comment thread compass/extraction/water/plugin.py Outdated
Comment thread docs/source/dev/advanced_plugin_development.rst Outdated
@ppinchuk ppinchuk linked an issue Apr 21, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.57%. Comparing base (b48f975) to head (77a1b0d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
compass/extraction/water/plugin.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #411   +/-   ##
=======================================
  Coverage   55.57%   55.57%           
=======================================
  Files          61       61           
  Lines        5681     5681           
  Branches      531      531           
=======================================
  Hits         3157     3157           
  Misses       2476     2476           
  Partials       48       48           
Flag Coverage Δ
unittests 55.57% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk merged commit 6ef5ad4 into main Apr 22, 2026
26 checks passed
@ppinchuk ppinchuk deleted the pp/minor_bug_fixes branch April 22, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixed a known bug dependencies Issues/pull requests related to a dependency p-high Priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a warning for missing local source document

4 participants