Removed unused imports from all python files#14
Merged
Conversation
Contributor
|
could you remove out the last line in simulate.py: os.chown(output_fname, uid, gid)? Have you pass the run? (refer to the run command in issue#2) |
Collaborator
Author
|
@lijiyao919 I can yeah. Looks like we've ran into this issue before as documented in the windows installation instructions: I did run into this attribute error while running but it looks like I'm still getting outputs. |
Contributor
|
looks good. |
lijiyao919
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all unused imports from the python files using VSCode and Flake8 to identify imports that are unused. I ran the simulation and didn't notice any issues, but please test this branch on your end and let me know if you have any concerns!
Closes #6