refactor code for models.py & remove unused models in configs#47
Merged
lijiyao919 merged 1 commit intomainfrom Jul 26, 2024
Merged
refactor code for models.py & remove unused models in configs#47lijiyao919 merged 1 commit intomainfrom
lijiyao919 merged 1 commit intomainfrom
Conversation
lijiyao919
requested review from
jhoshiko and
zihaolzh
and removed request for
jhoshiko and
zihaolzh
zihaolzh
approved these changes
Jul 26, 2024
Contributor
zihaolzh
left a comment
zihaolzh
left a comment
There was a problem hiding this comment.
Yes we have discussed about removing these models. Thanks for doing that Jiyao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jhoshiko