Skip to content

Methanol: Sprucing up plots for white paper#307

Merged
kbrunik merged 4 commits into
NatLabRockies:developfrom
jmartin4u:meoh-plot
Oct 17, 2025
Merged

Methanol: Sprucing up plots for white paper#307
kbrunik merged 4 commits into
NatLabRockies:developfrom
jmartin4u:meoh-plot

Conversation

@jmartin4u
Copy link
Copy Markdown
Collaborator

Sprucing up plots for white paper

Tiny, tiny PR just pulling in the changes in the plot of the methanol example, and adding a couple of references to the tech_config.yaml

Type of Contribution

  • Feature Enhancement
    • New Technology Model
  • Bug Fix
  • Documentation Update
  • CI Changes
  • Other (please describe):

General PR Checklist

  • CHANGELOG.md has been updated to describe the changes made in this PR
  • Documentation
    • Docstrings are up-to-date
    • Related docs/ files are up-to-date, or added when necessary
    • Documentation has been rebuilt successfully
    • Examples have been updated (if applicable)
  • Tests pass (If not, and this is expected, please elaborate in the tests section)
  • Added tests for new functionality or bug fixes
  • PR description thoroughly describes the new feature, bug fix, etc.

New Technology Checklist

  • Performance Model: Technology performance model has been implemented and follows H2Integrate patterns (if applicable)
  • Cost Model: Technology cost model has been implemented (if applicable)
  • Tests: Unit tests have been added for the new technology
    • Performance model tests (if applicable)
    • Cost model tests (if applicable)
    • Integration tests with H2Integrate system
  • Example: A working example demonstrating the new technology has been created
    • Example has been tested and runs successfully in test_all_examples.py
    • Example is documented with clear explanations in examples/README.md
      • Input file comments
      • Run file comments
  • Documentation:
    • Technology documentation page added to docs/technology_models/
    • Technology added to the main technology models list in docs/technology_models/technology_overview.md
  • Integration: Technology has been properly integrated into H2Integrate
    • Added to supported_models.py
    • If a new commodity_type is added, update create_financial_model in h2integrate_model.py
    • Follows established naming conventions outlined in docs/developer_guide/coding_guidelines.md

Related issues

Impacted areas of the software

  • examples/03_methanol/co2_hydrogenation_doc/plot_co2h_methanol.py - Spruced up plots
  • examples/03_methanol/co2_hydrogenation_doc/tech_config_co2h.yaml - Added sources for storage costs

Additional supporting information

Test results, if applicable

@jmartin4u jmartin4u requested a review from kbrunik October 16, 2025 22:24
@kbrunik kbrunik merged commit 4a7afa7 into NatLabRockies:develop Oct 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants