Skip to content

Conversation

@kbrunik
Copy link
Collaborator

@kbrunik kbrunik commented Oct 27, 2023

  • Modified pv capacity_factors calculation in HybridSimulation to ac capacity factor by multiplying system capacity by inverter loading ratio to get kWh (ac) / kW (ac)
  • Added getter/setter for dc_ac_ratio
  • Modified PVPlant capacity_factor to ac capacity factor calculation compatible with PySAM v3.0.0
  • Added pv plant_area property
  • Added pv plant_mass property
  • Updated tests

@kbrunik kbrunik changed the title Solar mod Solar plant updateas Oct 27, 2023
@kbrunik kbrunik changed the title Solar plant updateas Solar plant updates Oct 27, 2023
@kbrunik kbrunik requested a review from camirmas October 27, 2023 19:59
@kbrunik kbrunik mentioned this pull request Oct 27, 2023
@kbrunik kbrunik requested a review from dguittet October 27, 2023 20:07
"""Estimated Total Module Area [m2]"""
if self.approx_nominal_efficiency == 0:
raise ValueError("approx_nominal_efficiency cannot be zero.")
return self._system_model.SystemDesign.system_capacity / self.approx_nominal_efficiency
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the area is the system capacity divided by an efficiency? Shouldn't it be a kw per m2 value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the units don't make sense, which is what I had messaged you about via Teams. This is based on an estimate in the SAM GUI for pvwatts8, we talked about getting a more specific area calculation for each module type in the future but thought this would be alright in the mean time.

Copy link
Collaborator

@dguittet dguittet Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use 11.092 kg/m2 as the default value, taken from the SAM Transient Thermal Model? There's even a reference if you need to explain it:

Prilliman, M.; Stein, J. S.; Riley, D.; Tamizhmani, G. (2020). Transient Weighted Moving-Average Model of Photovoltaic Module Back-Surface Temperature. IEEE Journal of Photovoltaics. 8 pp. Volume 10 No. 4.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the mass calculation in 66d87e6 to use 11.092kg/m2.

Are you interested in me updating the area calculation to a different method?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, area! There's a file pv_module.py in HOPP that contains the PVWatts default module that has module_width and module_height and module_power so you could use that to set up the multiplier

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use get_module_attribs to get PVWatts module_area and module_power in 721f11b

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kbrunik kbrunik merged commit 4e450fd into NatLabRockies:develop Nov 7, 2023
@kbrunik kbrunik deleted the solar-mod branch November 8, 2023 18:26
This was referenced Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants