Skip to content

yaml file changes to build server packages for all branches, on Mac a…#294

Merged
rHorsey merged 5 commits intodevelopfrom
gitlabCiYml
Mar 2, 2018
Merged

yaml file changes to build server packages for all branches, on Mac a…#294
rHorsey merged 5 commits intodevelopfrom
gitlabCiYml

Conversation

@evanweaver
Copy link
Copy Markdown
Contributor

…nd Windows, and upload to S3 bucket "openstudio-builds/CI" with unique naming specifying version and SHA in package names.

…nd Windows, and upload to S3 bucket "openstudio-builds/CI" with unique naming specifying version and SHA in package names.
@nllong
Copy link
Copy Markdown
Member

nllong commented Feb 28, 2018

Just want to make sure that the SHA is the git commit SHA, correct?

@evanweaver
Copy link
Copy Markdown
Contributor Author

Yep, that's it.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 28, 2018

Coverage Status

Coverage remained the same at 60.607% when pulling ac3e6de on gitlabCiYml into 66a9b1a on develop.

@rHorsey
Copy link
Copy Markdown
Contributor

rHorsey commented Feb 28, 2018

@evanweaver You can remove the --with-test-develop from the openstudio_meta command. #293 has fixed that issue for me.

@rHorsey
Copy link
Copy Markdown
Contributor

rHorsey commented Feb 28, 2018

Merging this branch to be even with develop to fix AppVeyor commit testing.

@rHorsey
Copy link
Copy Markdown
Contributor

rHorsey commented Mar 1, 2018

@evanweaver Do you want to remove those --with-test-develop flags before we merge?

@evanweaver
Copy link
Copy Markdown
Contributor Author

@rHorsey please see my commit from earlier today

@rHorsey rHorsey removed the question label Mar 2, 2018
@rHorsey rHorsey merged commit ab71597 into develop Mar 2, 2018
@rHorsey rHorsey deleted the gitlabCiYml branch March 2, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants