Fix #1722 - CoilSystemCooling Water/DX HeatExchangerAssisted problems#3449
Conversation
…emCoolingWaterHeaterExchangerAssisted
…Node created in CoilSystemCoolingWaterHeaterExchangerAssisted
… the cooling coil though
…mps of CoilSystem **DX**
…coil Should accept Coil:Cooling:DX:SingleSpeed or Coil:Cooling:DX:VariableSpeed
…the Cpp (so aws documentation is wrong for eg..)
…tainingZoneHVACComponent
…mponent mistmatch
macumber
left a comment
There was a problem hiding this comment.
Added some minor comments. Is there a regression test that covers the configurations of equipment in this PR? This seems like we need to test the specific configurations of equipment to get at interactions between them, basically we'd like to test all the control paths with a regression test
As linked above, I added one test for the water version and another for the dx version in NatLabRockies/OpenStudio-resources#68. Isn't that enough? I'm a bit unclear about what you mean by control path here, does this mean I should also test the DX version with a Cooling:Cooling:DX:VariableSpeed in addition to the SingleSpeed one? Do I also need to test the water one inside of a unitary sys? I don't see any potential other configuration but I might be missing the point (For what it's worth, I don't think the vast majority of the openstudio-resources test currently check for every possible combination there is) |
Fix #1722 - CoilSystemCooling Water/DX HeatExchangerAssisted problems
Changelog:
\object-listfor theCoilSystem:Cooling:DX:HeatExchangerAssistedcooling coil: should allow bothCoilCoolingDXSingleSpeed(already the case) ANDCoilCoolingDXVariableSpeedSPM:MixedAirin FT for theCoilSystemCoolingWaterHeatExchangerAssisted's cooling coil outletchildren()andclone()forCoilSystemCoolingWaterHeatExchangerAssistedcontainingHVACComponent()for all potential children for these twoCoilSystemCoolingXXXobjects, and modify theiraddToNodeto disallow connection if part of aCoilSystemCoolingXXXsetCoolingCoilmethods to allow these two CoilSystem as appropriate