Fix #3421 - Fix forward translator issues in CoilHeatingDesuperheater and CoilWaterHeatingDesuperheater#3452
Merged
macumber merged 10 commits intoNatLabRockies:developfrom Mar 21, 2019
Conversation
…was wrapped inside a CoilSystem:Cooling:DX
… a quick unit test for ZoneHVACPTAC to test it
macumber
reviewed
Mar 20, 2019
macumber
previously requested changes
Mar 20, 2019
Contributor
macumber
left a comment
macumber
left a comment
There was a problem hiding this comment.
Looks good except for minor change to remove the OS_ASSERT(false) in preference to E+ run time failure
rraustad
reviewed
Apr 5, 2019
| std::string objectType; | ||
| std::string objectName; | ||
|
|
||
| if (_heatingSource->iddObject().type() == IddObjectType::CoilSystem_Cooling_DX) { |
There was a problem hiding this comment.
@jmarrec I don't know this syntax nor what this translator is trying to accomplish, just a question here. What if the desuperheater coil is in a UnitarySystem?
Collaborator
Author
There was a problem hiding this comment.
@rraustad Same pretty much, the coil is translated and returned, and it's the nodes of the coil (and not the parent unitary) that end up there. Does that make sense?
Source:
- https://github.com/NREL/OpenStudio/blob/b32c3d6fe31f7401a0be860ed301039b99ea98d9/openstudiocore/src/energyplus/ForwardTranslator.cpp#L973:L980
- translateCoilDXSingleSpeedWithoutUnitary you'll see it's the coil that's returned. The naming of the method can be confusing because it's this one that's called when the coil is already inside a unitary, and if not then another method is called where a CoilSystemDX is added ("With unitary") and it is for this case that I added logic to retrieve the actual coil and not the parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3421 - Fix forward translator issues in CoilHeatingDesuperheater and CoilWaterHeatingDesuperheater
If the Heating Source is a DX cooling coil, and if this DX coil is not already inside another component, the FT will wrap it into a CoilSystem:Cooling:DX wrapper and return that. Cf: ForwardTranslator::isHVACComponentWithinUnitary and translateModelObject for CoilCoolingDXSingleSPeed
Except that the desuper heater IDD will not accept this object type, so it gets remove. I added code to retrieve the actually DX Cooling coil from the wrapper if it exists.
Added unit tests