Fix #2798 - Show Uneditable measure name in addition to Display Name#3465
Merged
macumber merged 4 commits intoNatLabRockies:developfrom Mar 21, 2019
Merged
Conversation
jmarrec
commented
Mar 21, 2019
| // TODO: JM 2019-03-21 Should I ensure that I get just the measure directory NAME and not a path? | ||
| // Within OS App there's no risk since the measure_dir_name doesn't include "../../" or absolute path | ||
| // (QFileInfo.fileName) | ||
| if (boost::optional<std::string> name = m_step.measureDirName()){ |
Collaborator
Author
There was a problem hiding this comment.
Need to test that out...
macumber
reviewed
Mar 21, 2019
|
|
||
| if(applyMeasureNow){ | ||
| nameLineEdit->setReadOnly(true); | ||
| nameNonEditableLineEdit->setVisible(false); |
Contributor
There was a problem hiding this comment.
@jmarrec just curious, why not show this as read only in apply measure now?
Collaborator
Author
There was a problem hiding this comment.
Yeah I don't know either, let me change that real quick. (plus, I would actually need to hide the title too if hide the input box)
(and fix some discrepancies in formatting)
Collaborator
Author
|
One thing that I discovered is that "Modeler Description" is always empty in Apply Now for some reason. Affects 2.7.1 too On Measures tab, just fine:
Apply Now, empty:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Initially tried another approach in #3438, after discussion I am starting from a clean slate)
Fix #2798 - Show Uneditable measure name in addition to Display Name
Upon dragging a new measure: