Fix #4014 download from BCL#4021
Merged
Merged
Conversation
tijcolem
added
the
Pull Request - Ready for CI
…rkflow allows to load embedded gems when using bundler
20 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4014
Seems host
bcl.nrel.govcan be slow to download for certain bcl components. For instance, in our unit tests, componenta10331a0-edc7-0131-840c-48e0eb16a403can exceed the cpprestsdk default 30 sec response time which closes the client handle and results in a unit test failure.You can manually reproduce the slow response time by running a simple wget to the api endpoint for that component:
wget https://bcl.nrel.gov/api/component/download?uids=a10331a0-edc7-0131-840c-48e0eb16a403This can change of course due to client/server network speeds.
Increasing from 30 to 60 seems to fix.