Merged
Conversation
Bill-Becker
approved these changes
Apr 23, 2024
Collaborator
Bill-Becker
left a comment
There was a problem hiding this comment.
Nice work! Just a suggestion to remove some excess description from the Changelog.
Collaborator
Author
|
@adfarth, seems like all the test are passing now. Please let me know if its okay, once you've had a change to review. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
default update for 'PV tilt'.
core/pv.jla change was made to make sure we are using the same assumptions as PVWatts guidelines, the defaulttiltangle for a fixed array should be 20 degrees, irrespective of it being a rooftop(0)or ground-mounted (open-rack)(1)system. By default thetiltwill be set to 20 degrees for fixed ground-mount and rooftop, and 0 degrees for axis-tracking (array_type = (2), (3), or (4))What is the current behavior?
(You can also link to an open issue here)
The current default
PV tilt anglefor a rooftop is set to 10 degrees and for fixed ground-mount to 20 degrees.What is the new behavior (if this is a feature change)?
The new behavior sets the tilt angle for fixed PV rooftop and ground-mount to 20 degrees and for axis-tracking to 0 degrees. This aligns it with the pvwatts defaults.
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Specify a
PV tilt angleif they may need to use a lower tilt angle for their fixed arrays than the new default of 20 due to hardware cost, wind, or other consideration considerationOther information: