Skip to content

Conversation

@mjprilliman
Copy link
Collaborator

Description

-Add summary graphs showing stack of monthly from battery, grid, system to load
-Add summary graphs showing stack of monthly energy charges, demand tou charges, demand flat charges, and fixed charges
-Add default timeseries graph showing stacked area plot of battery, grid, system to load lifetime timeseries; Battery SOC line graph on right-hand Y-axis
-Remove summary page PV loss graphs for technologies where Loss Diagram already exists
-Requires help documentation update from @cpaulgilman explaining 'Edit view settings and graph scaling' window

image

image

image

Fixes #1871

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added enhancement battery requires help revision Requires a Help revision before releasing public version labels Oct 22, 2024
@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Oct 22, 2024
@mjprilliman mjprilliman self-assigned this Oct 22, 2024
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

My only suggestion is to have the time series graph zoom in to the first 7 days of the year to show one full week.

Help revision:

Time Series

image

Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this as well! Especially how the rate components show the energy charges phasing out as the net metering credits build up.

@mjprilliman
Copy link
Collaborator Author

mjprilliman commented Oct 28, 2024

I like it!

My only suggestion is to have the time series graph zoom in to the first 7 days of the year to show one full week.

Help revision:

Time Series

image

@cpaulgilman We had discussed maybe adding a section going over the controls in the toolbar with a screenshot of the dialog, but I think your note here covers it well so I think it is fine as is.

I can update to show the first week of results for the hourly default, but I don't think it will scale automatically at the moment for the timestep in the default configuration.

@cpaulgilman
Copy link
Collaborator

@cpaulgilman We had discussed maybe adding a section going over the controls in the toolbar with a screenshot of the dialog, but I think your note here covers it well so I think it is fine as is.

I added a section to the Time Series topic in help to describe the options in the View Settings window:
results-time-series-view-settings.pdf

I'm not sure what the Show sum over time step option does or that it works at all, so I did not include a description of that option.

@mjprilliman mjprilliman merged commit bbbe46f into develop Oct 28, 2024
@mjprilliman mjprilliman deleted the batt-dispatch-visual branch October 28, 2024 18:28
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Nov 21, 2024
cpaulgilman added a commit that referenced this pull request Dec 7, 2024
Grid limits do not affect electricity imports from the grid.

Revise IPH molten salt linear Fresnel topics

Power tower heliostast pivot point height definition.

New Financial Parameters topic for LCOH Calculator.

Wind wake loss inputs NatLabRockies/ssc#1186

Annual energy and monthly energy label updates: NatLabRockies/ssc#1236

Replace parentheses with commas for installation cost units

Battery availability loss. NatLabRockies/ssc#1241

Tidal Energy Converter page revisions for new options, see #1807.

New net billing with carryover options. NatLabRockies/ssc#1200

IPH MSLF revisions: #1444

Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf.

PV GCR affects output for bifacial modules.

Revise report generator topic to explain template not available for some configurations.

Add topics for IPH financial models

Generic system to custom generatio profile

Standalone battery time step

New autographs and default graphs for battery configurations: #1884

System Availability three hour option for marine, "hourly" to "time series"

## October 24, 2024

Update Cambium note about years for Cambium 2023

Battery dispatch (BTM and FOM) battery can charge from grid-limited system power

Grid limits battery can charge from grid-limited system power

Project with 100% debt results in IRR = NaN

Revise real discount rate description

Geothermal system availability losses

Revise metrics topics to facilitate navigation.

Revise weather file format to include CSV for wind

Revise PV subhourly clipping "Allen method"

Revise Cost of Acquiring Financing.
@cpaulgilman cpaulgilman mentioned this pull request Dec 7, 2024
15 tasks
cpaulgilman added a commit that referenced this pull request Dec 10, 2024
* Help revisions for SAM 2024.12.12

Grid limits do not affect electricity imports from the grid.

Revise IPH molten salt linear Fresnel topics

Power tower heliostast pivot point height definition.

New Financial Parameters topic for LCOH Calculator.

Wind wake loss inputs NatLabRockies/ssc#1186

Annual energy and monthly energy label updates: NatLabRockies/ssc#1236

Replace parentheses with commas for installation cost units

Battery availability loss. NatLabRockies/ssc#1241

Tidal Energy Converter page revisions for new options, see #1807.

New net billing with carryover options. NatLabRockies/ssc#1200

IPH MSLF revisions: #1444

Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf.

PV GCR affects output for bifacial modules.

Revise report generator topic to explain template not available for some configurations.

Add topics for IPH financial models

Generic system to custom generatio profile

Standalone battery time step

New autographs and default graphs for battery configurations: #1884

System Availability three hour option for marine, "hourly" to "time series"

## October 24, 2024

Update Cambium note about years for Cambium 2023

Battery dispatch (BTM and FOM) battery can charge from grid-limited system power

Grid limits battery can charge from grid-limited system power

Project with 100% debt results in IRR = NaN

Revise real discount rate description

Geothermal system availability losses

Revise metrics topics to facilitate navigation.

Revise weather file format to include CSV for wind

Revise PV subhourly clipping "Allen method"

Revise Cost of Acquiring Financing.

* Help revisions

Revise "receiver startup delay time" and "receiver startup delay energy fraction" descriptions for trough and Fresnel models.

Fix remaining references to "generic system" model.

---------

Co-authored-by: Steven Janzou <steven@janzouconsulting.com>
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release battery enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement summary metric and graph updates for battery configs

4 participants