Fix SAM #1918 and test on Windows 11 and MacOS 15.1.1 with MATLAB #1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Tested on widows 11 Tested on MacOS 15.1.1 |
mjprilliman
approved these changes
Dec 6, 2024
src/codegenerator.cpp
Outdated
| } | ||
| else { | ||
| //else { | ||
| /* skip fallback per SAM issue 1918 |
Collaborator
Author
There was a problem hiding this comment.
Removed commented code as requested - was initially left as a fallback position but more confusing and out of date. Thanks for the future maintenance request!
cpaulgilman
added
the
added to release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, build SAM and SAM-private if you would like (delete build_windows folder in SAM-private) and run SAM and generate code for some language and check that latest sscapi.h and ssc.dll (or.so or .dylib) is included in the generated code folder.