Skip to content

Remove duplicate utility bill variables#2009

Merged
cpaulgilman merged 6 commits intopatchfrom
sam-1879-utility-bill-vars
Feb 21, 2025
Merged

Remove duplicate utility bill variables#2009
cpaulgilman merged 6 commits intopatchfrom
sam-1879-utility-bill-vars

Conversation

@cpaulgilman
Copy link
Collaborator

Duplicate variables for electricity bill with system and electricty bill without sytem:

elec_cost_with_system, "Electricity bill with system", "$/yr"
utility_bill_w_sys, "Electricity bill with system", "$"

elec_cost_without_system, "Electricity bill with system", "$/yr"
utility_bill_wo_sys, "Electricity bill with system", "$"

I think the "elec_cost_" variables were originally added for the Third Party Ownership Host-Develpoer host indifference point metric (formerly known as "not to exceed" or "NTE"), and then ended up in other parts of the code. There doesn't seem to be any reason to have two versions of the electricity bill variables.

Note that this replaces the variables in older versions of the utilityrate module -- we can revert that if we only want to change utilityrate5.

This PR and the associated NatLabRockies/ssc#1276 include checking and replacing the variables in the following:

  • Metrics, autographs, and cashflows scripts
  • Report generator templates and scripts
  • SSC test scripts
  • Macros, including quickstart
  • Cashflow Send-to-Excel workbooks
  • LK script and PySAM samples in SAM, SSC, and PySAM repos.

Fixes #1879

Goes with NatLabRockies/ssc#1276

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added bug financial Financial model labels Feb 12, 2025
@cpaulgilman cpaulgilman added this to the 2024 Release Patch 1 milestone Feb 12, 2025
@cpaulgilman cpaulgilman self-assigned this Feb 12, 2025
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All defaults running without issue and mini grid and wind wizard working and since outputs - no version upgrade necessary. Thanks for updating!

I committed the updated api files for when we merge into develop or patch for the new release or patch 1, respectively.

image

@cpaulgilman cpaulgilman merged commit c83d037 into patch Feb 21, 2025
8 checks passed
@cpaulgilman cpaulgilman deleted the sam-1879-utility-bill-vars branch February 21, 2025 22:56
@brtietz brtietz modified the milestones: 2024 Release Patch 1, SAM Spring 2025 Release Mar 7, 2025
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release bug financial Financial model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annual Electricity bill with and without system duplicated for FOM and BTM systems

3 participants