Remove duplicate utility bill variables#2009
Merged
cpaulgilman merged 6 commits intopatchfrom Feb 21, 2025
Merged
Conversation
sjanzou
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Duplicate variables for electricity bill with system and electricty bill without sytem:
elec_cost_with_system, "Electricity bill with system", "$/yr"utility_bill_w_sys, "Electricity bill with system", "$"elec_cost_without_system, "Electricity bill with system", "$/yr"utility_bill_wo_sys, "Electricity bill with system", "$"I think the "elec_cost_" variables were originally added for the Third Party Ownership Host-Develpoer host indifference point metric (formerly known as "not to exceed" or "NTE"), and then ended up in other parts of the code. There doesn't seem to be any reason to have two versions of the electricity bill variables.
Note that this replaces the variables in older versions of the utilityrate module -- we can revert that if we only want to change utilityrate5.
This PR and the associated NatLabRockies/ssc#1276 include checking and replacing the variables in the following:
Fixes #1879
Goes with NatLabRockies/ssc#1276
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.