Resolves issue 138 and related bugs#139
Merged
tapajyoti-ghosh merged 19 commits intodevelopfrom Mar 17, 2022
Merged
Conversation
…print statement
Collaborator
|
Unfortunately this bug is not yet resolved. A mismatch between timesteps and annual transactions calculation in the DES model is affecting calculations still. |
rjhanes
commented
Mar 14, 2022
Collaborator
Author
rjhanes
left a comment
rjhanes
left a comment
There was a problem hiding this comment.
@TJTapajyoti @akey7
There's a couple of aesthetic changes (print statements and one super-long comment to be removed), and if we're changing solvers for the LCIA calculations we might need to update that in the manuscript. I didn't see any functionality that looked off.
I don't think this PR will conflict with #137 but haven't dug into that in detail.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge only once all related issues are resolved and committed.