Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
===========================================
+ Coverage 20.94% 57.32% +36.37%
===========================================
Files 7 9 +2
Lines 253 478 +225
===========================================
+ Hits 53 274 +221
- Misses 200 204 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
|
@grantbuster Yu and I have gone back and forth a bunch over doc strings and linting so I'll let you do the first review. |
Collaborator
|
@xieyupku I don't think we need the |
bnb32
reviewed
Mar 30, 2023
farms/farms.py
Outdated
| return np.where(clear_mask, np.nan, ghi),\ | ||
| np.where(clear_mask, np.nan, dni_farmsdni),\ | ||
| np.where(clear_mask, np.nan, dni0) | ||
| # print( theta00, idx, muomega ) |
Collaborator
There was a problem hiding this comment.
this commented out code should be removed
Member
|
i dont think i commented this previously: we should increment the version before we merge this so we can do a release. |
bnb32
force-pushed
the
FARMS-DNI
branch
2 times, most recently
from
a87f0e1 to
f5eb1e4
Compare
bnb32
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new DNI computation by FARMS-DNI