changed DHI calculation to not zero out DNI when dhi is calculated as…#12
Merged
changed DHI calculation to not zero out DNI when dhi is calculated as…#12
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 57.32% 57.68% +0.36%
==========================================
Files 9 9
Lines 478 475 -3
==========================================
Hits 274 274
+ Misses 204 201 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bnb32
approved these changes
Jun 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
changed DHI calculation to not zero out DNI when dhi is calculated as…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… negative