Skip to content

Conversation

@ejsimley
Copy link
Collaborator

@ejsimley ejsimley commented Nov 8, 2024

Feature or improvement description
This pull request addresses issue #235 by adding functions set_wd_by_upstream_turbines and set_wd_by_upstream_turbines_in_radius to the dataframe_manipulations module. The reason for these functions is that wind directions measured by waked turbines can contain biases due to wake effects. Therefore, it could be advantageous to only use unwaked turbines to estimate the wind direction. These functions first use the average wind direction over all turbines to identify the unwaked turbines. Then the unwaked turbines (or unwaked turbines within the specified radius for set_wd_by_upstream_turbines_in_radius ) are used to compute the final wind direction signal.

Related issue, if one exists
This PR closes issue #235

Impacted areas of the software
The dataframe_manipulations module

Test results, if applicable
Tests added in "dataframe_manipulations_test.py"

@ejsimley ejsimley requested a review from paulf81 November 8, 2024 17:21
@ejsimley ejsimley self-assigned this Nov 8, 2024
Copy link
Collaborator

@paulf81 paulf81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @ejsimley , nice and clean!

@ejsimley ejsimley merged commit 15f9241 into NatLabRockies:develop Nov 11, 2024
@ejsimley ejsimley deleted the feature/set_wd_by_upstream_turbines branch November 11, 2024 22:58
@paulf81 paulf81 mentioned this pull request Dec 20, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants