[Bugfix]: Update geometric yaw optimizer layout when called during layout optimization#706
Merged
rafmudaf merged 6 commits intoNatLabRockies:developfrom Oct 4, 2023
Merged
Conversation
rafmudaf
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug that I missed when I created #621. When the geometric yaw code is called from within a layout optimization, the layout should be updated with each call, but this was not happening---instead, the yaw angles for the initial layout were being given.
This fixes the bug. One artifact of the fix is that any child optimization class of$x$ and $y$ locations of the turbines). This is already the case for
LayoutOptimizationBasethat calls_get_geoyaw_angles()withself.enable_geometric_yaw = Trueis required to have attributesself.xandself.y(representing theLayoutOptimizationScipyandLayoutOptimizationPyOptSparse.The difference (although slight) can be observed by running example 16c.
Ready for review and merge.