Update PySAM to v6.0.0 #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging NREL/develop into local branch pre-pull-request
brookeslawski
commented
Feb 19, 2025
| echo "Conda installation not found. Please ensure Conda is installed and in your PATH." | ||
| exit 1 | ||
| fi | ||
| echo "$CONDA_PATH" |
Collaborator
Author
There was a problem hiding this comment.
Not sure if I'm the only one, but HOPP has trouble finding my conda env so I thought this would be nice to add in case others have that issue too. Just helps with debugging
brookeslawski
commented
Feb 19, 2025
| py_sim_type: SolarPySAM | ||
| verbose: True # flag to print debugging statements | ||
| weather_file_name: inputs/Flatirons_solar_data_highDNI.csv | ||
| weather_file_name: inputs/Flatirons_solar_data_sunset.csv # inputs/Flatirons_solar_data_highDNI.csv # |
Collaborator
Author
There was a problem hiding this comment.
I chopped the solar input file to include the sunset timeframe, which includes variations in irradiance large enough to result in noticeable variations in solar farm output. Previously, the highDNI input data just showed a constant solar farm power output because the irradiance was so high.
Merging in develop with updated lisence
genevievestarke
approved these changes
Mar 7, 2025
misi9170
pushed a commit
to misi9170/hercules
that referenced
this pull request
Mar 10, 2025
* preparing inputs for running hercules using ARM solar data * running OK ARM solar data * running hercules using solar data from ARM in OK * improving how solar pysim grabs data from solar weather file based on simulation time * adding input solar data * adding verbose flag to turn on and off debugging print statements * trying to run with new json file to prep for varying system size * adding more weather input files * adding files for testing and to find my mamba env * updating installation instructions * updating HPC installation instructions * updating desired value in test to match PySAM v6 output * Update toml file with new pysam version --------- Co-authored-by: Genevieve Starke <genevieve.starke@nrel.gov>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hercules had previously used PySAM v4.2.0, so this PR upgrades the PySAM version to the latest, which is v6.0.0.
This upgrade involved the following changes:
inputs/Flatirons_solar_data_highDNI.csvcalledinputs/Flatirons_solar_data_sunset.csv, which shows more dynamic fluctuations in the solar farm power output - this is better for testing the solar module