mypy errors

[nreinicke]

Closes #90 by picking off the large list of mypy errors.

[robfitzgerald]

nice. i know you didn't call this ready but i loaded it up and found all tests pass and mypy says "Found 114 errors in 32 files (checked 204 source files)". that's good progress.

when i run $ mypy tests it tells me There are no .py[i] files in directory 'tests' which is wonksville usa, then i try $ mypy . and i get Found 114 errors in 32 files (checked 207 source files) so it's picking up a few more, but not all of the files in tests/. have you figured out a work-around?

[nreinicke]

Thanks for looking through this! I actually explicitly excluded the tests from mypy so I could focus on the core package but we could remove that and start working on all the errors.

[nreinicke]

Also, if you do mypy --install-types I think you'll see more errors as mypy installs the types for various packages that aren't installed by default.

[nreinicke]

Phew okay, I've gotten through all the mypy errors and this is now ready for review.

I've also added a new CI step that runs mypy to check for type errors.

[robfitzgerald]

@nreinicke i'm not sure why, but, for some reason, when i sync your branch, i don't have the fix for vehicle_state_ops that _ignore_s the type check for vehicle_state.route. my copy of your branch:

    elif not hasattr(vehicle.vehicle_state, "update_route"):
        return (
            SimulationStateError(
                f"vehicle state does not have update_route method; context {context}"
            ),
            None,
        )
    else:
        route = vehicle.vehicle_state.route  # throws mypy error

that's even after doing a fresh clone of the repo and pulling to the ndr/90-mypy-errors branch. 🤔

edit: oh, wait, just stepped through the file changes, and it doesn't look like there's a change on line 190. here's the error message i get:

(hive) rfitzger-36698s:hive rfitzger$ mypy . --ignore-missing-imports
nrel/hive/state/vehicle_state/vehicle_state_ops.py:190: error: "VehicleState" has no attribute "route"
Found 1 error in 1 file (checked 243 source files)

thank you for this heroic effort!

[robfitzgerald]

i had an issue but after upgrading my version of mypy it was resolved.

this is super awesome when mixed with the CI call. thank you!!! 🐝