Conversation
robfitzgerald
requested changes
Dec 5, 2022
Collaborator
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
smooth. just a comment on a deleted test, but i think this all looks swell.
Collaborator
|
@nreinicke hey, actually, should an init function be also allowed to update the Environment? edit: for example, if a user wanted to inject their own custom mechatronics function |
Collaborator
Author
|
Yes, good point on the modification of the environment, I just added that in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates how we initialize a simulation to support injection of a custom road network at the highest level.
Now, an extension to the core library could call
run_sim()and pass a set of custom initialization functions.