add from polygon method to OSMRoadNetwork#121
Merged
Conversation
robfitzgerald
requested changes
Dec 14, 2022
Collaborator
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
i love the idea of making it easier, even built-in, to build a road network. that said, i don't love the idea of osmnx being a required dependency. if you can set this up where osmnx (and shapely) are optional dependencies (at the build level) and we do a check at the script level for the existence of the osmnx package (and throw if missing), then i think that would be the right move.
osmnx is like a framework-sized dependency, and getting it installed alongside other dependencies is difficult. i feel the same way about geopandas. i think it would be great to not require either of these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make building a new road network easier on the user, this adds a new
from_polygonclass method to theOSMRoadNetworkthat uses osmnx and shapely on the backend to build a road network.