pull out python 3.7 support#165
Merged
robfitzgerald merged 1 commit intomainfrom Apr 24, 2023
Merged
Conversation
nreinicke
force-pushed
the
ndr/remove-python-3.7-support
branch
from
c67b983 to
2c09862
Compare
Collaborator
|
Nice, sounds good to me! |
jhoshiko
approved these changes
Apr 24, 2023
Collaborator
Author
|
Not quite sure how to get rid of the stubborn expected 3.7 test since that shouldn't be required anymore:
|
Collaborator
Author
|
thanks to @erik-hasse for pointing out that 3.7 was a required test in the branch protection rules so just had to pull that out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In May of 2020, we added python 3.7 support since several of the reinforcement learning algorithms we were using did not yet support anything above 3.7. Since then the libraries like RLlib has been updated to support later versions of python. I think it makes sense to drop this now, opening us up to use 3.8 and up specific features.