Nrel#166 automatically download road network if doesnt exist#175
Conversation
clintonsteiner
force-pushed
the
NREL#166_automatically_download_road_network_if_doesnt_exist
branch
from
eaa1a63 to
259a4f7
Compare
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
solid start and one step closer to a really simple way for people to use HIVE.
i have some requests for fixes and one question as well.
🐝
| polygon=polygon_union, | ||
| ) | ||
| else: | ||
| raise IOError("Must supply a road network file when using the osm_network") |
There was a problem hiding this comment.
this is the error message for omission of either road_network or geofence_file. the error should reflect this, perhaps via raise IOError("Must supply either a road network or geofence file when using the osm_network")
| ) from e | ||
|
|
||
| ox.settings.all_oneway = True | ||
| ox.settings.use_cache = False |
There was a problem hiding this comment.
Deprecated and causes errors on our run
There was a problem hiding this comment.
I wonder if we could set the cache folder instead to cache the road network results in the scenario folder using the cache_folder setting from here?
There was a problem hiding this comment.
Talked with Nick and we got this updated, unsure if I love the implementation though. Open to suggestions
This reverts commit 2016911.
clintonsteiner
force-pushed
the
NREL#166_automatically_download_road_network_if_doesnt_exist
branch
from
259a4f7 to
6ff08f4
Compare
…_if_doesnt_exist Signed-off-by: clintonsteiner <47841949+clintonsteiner@users.noreply.github.com>
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
lgtm, thanks for adding this!
3 participants
No description provided.