Remove pandas dependency by decoupling csv writing from dataframes#176
Merged
nreinicke merged 28 commits intoNatLabRockies:mainfrom Apr 25, 2023
Merged
Remove pandas dependency by decoupling csv writing from dataframes#176nreinicke merged 28 commits intoNatLabRockies:mainfrom
nreinicke merged 28 commits intoNatLabRockies:mainfrom
Conversation
machallboyd
changed the title
Contributor
Author
|
This is finally passing tests. |
nreinicke
reviewed
Apr 25, 2023
Collaborator
There was a problem hiding this comment.
I think we want to bring this back since we supply a command line tool that uses it:
https://github.com/NREL/hive/blob/a15b8bad16b722564418c708c2d7a3d68bca1f41/pyproject.toml#L60
But, this doesn't use pandas so hopefully that's a trivial ask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all dependencies on
pandas, which was mostly being used to write CSVs.At the moment, there's no tests to see if it's producing the same CSVs as before.
Also removes two
run_...files which were not in active use.