Skip to content

Rjf/jkirsh2 issue126 formatting#179

Merged
nreinicke merged 5 commits intomainfrom
rjf/jkirsh2-issue126-formatting
Apr 25, 2023
Merged

Rjf/jkirsh2 issue126 formatting#179
nreinicke merged 5 commits intomainfrom
rjf/jkirsh2-issue126-formatting

Conversation

@robfitzgerald
Copy link
Copy Markdown
Collaborator

this PR applies the fixes requested in #174 while adhering to formatting rules (replaces #174)

@nreinicke nreinicke self-requested a review April 25, 2023 14:57
@robfitzgerald
Copy link
Copy Markdown
Collaborator Author

@nreinicke @jhoshiko i got the impression that jkirsh2 might not make it back for the formatting and if that's the case, this PR can supersede #174. i leave it to you to accept this one or wait for them on the other.

Copy link
Copy Markdown
Collaborator

@nreinicke nreinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 perfect, thanks @robfitzgerald and thanks @jkirsh2!!

@nreinicke nreinicke merged commit a15b8ba into main Apr 25, 2023
@nreinicke nreinicke deleted the rjf/jkirsh2-issue126-formatting branch April 25, 2023 14:59
This was referenced Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants