Conversation
Collaborator
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
makes sense. one question, maybe a straggler change from another PR
robfitzgerald
approved these changes
Apr 26, 2023
Collaborator
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
tested by fudging with the denver road network and saw both helpful warnings. i think that's enough to let the user know that something's wrong. thanks nick!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the networkx docs, the shortest path algorithm accepts a weight string and if that string does not appear on an edge, the weight defaults to 1. This makes sure that the travel time attribute exists on all the edges when importing a graph.
Closes #36