Skip to content

Bnb32/issue46#47

Merged
bnb32 merged 8 commits into
mainfrom
bnb32/issue46
Mar 11, 2022
Merged

Bnb32/issue46#47
bnb32 merged 8 commits into
mainfrom
bnb32/issue46

Conversation

@bnb32
Copy link
Copy Markdown
Collaborator

@bnb32 bnb32 commented Mar 11, 2022

Added ability to specify "debug_day" in config_nsrdb.json. If this is null things will run normally. If not null only debug_day will be run and all other jobs in doy_range will only be included in the status file.

Copy link
Copy Markdown
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, did you try it out?

@bnb32
Copy link
Copy Markdown
Collaborator Author

bnb32 commented Mar 11, 2022

looks good to me, did you try it out?

Yeah a bunch. The one thing that annoys me is the dummy runs are interpreted as failed so we get a message about that on new submissions. Changing that would require digging in reV though I guess. Otherwise it works well.

@bnb32 bnb32 merged commit ccf2059 into main Mar 11, 2022
@grantbuster
Copy link
Copy Markdown
Member

Thats fine though, its good if those jobs "fail" because then the pipeline wont move past the current step and those jobs will be submitted once you disable the debug feature

@grantbuster grantbuster deleted the bnb32/issue46 branch March 11, 2022 22:01
@bnb32
Copy link
Copy Markdown
Collaborator Author

bnb32 commented Mar 11, 2022

Thats fine though, its good if those jobs "fail" because then the pipeline wont move past the current step and those jobs will be submitted once you disable the debug feature

Yeah I'd just rather it not move past but not say theyre failed. Just nitpicking though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants