Skip to content

Wrapper for clearsky filter combining csi and pvlib models#412

Merged
mdeceglie merged 27 commits intoaggregated_filters_for_trialsfrom
wrapper-clearsky_filter
Apr 29, 2024
Merged

Wrapper for clearsky filter combining csi and pvlib models#412
mdeceglie merged 27 commits intoaggregated_filters_for_trialsfrom
wrapper-clearsky_filter

Conversation

@martin-springer
Copy link
Copy Markdown
Collaborator

@martin-springer martin-springer commented Apr 17, 2024

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (aggregated_filters_for_trials@26bb72d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
versioneer.py 0.00% 2 Missing ⚠️
rdtools/analysis_chains.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##             aggregated_filters_for_trials     #412   +/-   ##
================================================================
  Coverage                                 ?   71.70%           
================================================================
  Files                                    ?       13           
  Lines                                    ?     2820           
  Branches                                 ?        0           
================================================================
  Hits                                     ?     2022           
  Misses                                   ?      798           
  Partials                                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdeceglie mdeceglie merged commit 1f25b2f into aggregated_filters_for_trials Apr 29, 2024
@mdeceglie mdeceglie deleted the wrapper-clearsky_filter branch April 29, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants