Add checks to filter arguments for TrendAnalysis (Issue #377)#436
Add checks to filter arguments for TrendAnalysis (Issue #377)#436mdeceglie merged 9 commits intodevelopmentfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #436 +/- ##
===============================================
- Coverage 96.10% 96.08% -0.02%
===============================================
Files 11 11
Lines 2209 2250 +41
===============================================
+ Hits 2123 2162 +39
- Misses 86 88 +2 ☔ View full report in Codecov by Sentry. |
mdeceglie
left a comment
There was a problem hiding this comment.
The solution works great! Let's add some simple tests for the intended behavior
Done. |
|
Thank you for adding the unit tests. I suggest we also add some simple tests to the trend analysis as well: checking that every key we think should work does work (including ad_hoc) and checking that some bogus key in either |
added |
__init__.py