Release 3.1.1 - Eliminates floating-point imprecision on old pandas version#494
Merged
martin-springer merged 7 commits intomasterfrom Mar 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 96.18% 96.00% -0.18%
==========================================
Files 12 12
Lines 2280 2280
==========================================
- Hits 2193 2189 -4
- Misses 87 91 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdeceglie
reviewed
Mar 11, 2026
Comment on lines
+14
to
+16
| * Updated expected test values in ``test_clearsky_pvlib_analysis`` and | ||
| ``test_sensor_clearsky_pvlib_analysis`` to match corrected normalization | ||
| output, with wider CI tolerance to account for bootstrap nondeterminism. |
Collaborator
There was a problem hiding this comment.
I don't think I'm seeing these changes in this PR.
Collaborator
Author
There was a problem hiding this comment.
good catch this is left over from debugging. I'll remove it.
mdeceglie
reviewed
Mar 11, 2026
Comment on lines
+20
to
+21
| * Bumped minimum ``pvlib`` from 0.11.0 to 0.13.1. | ||
| * Bumped minimum ``xgboost`` from 1.6.0 to 1.7.0.post0. |
Collaborator
There was a problem hiding this comment.
These should be reflected in setup.py as well
mdeceglie
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where total_seconds() * 1e9 produced imprecise float values (e.g. 60000000000.00001) on older pandas versions (e.g. 1.4.4), causing gap detection in _t_step_nanoseconds, energy_from_power, and _aggregate to flag all data points as gaps.
Changes
Checklist
- [ ] Code changes are covered by tests- [ ] Code changes have been evaluated for compatibility/integration with TrendAnalysis- [ ] New functions added to__init__.py- [ ] API.rst is up to date, along with other sphinx docs pages- [ ] Example notebooks are rerun and differences in results scrutinized