Add import/export feature to torc-dash#128
Merged
daniel-thom merged 9 commits intomainfrom Feb 16, 2026
Merged
Conversation
- Add authorization to access group endpoints - Add integrity and crossorigin="anonymous" attributes to all 4 external <script> tags - Escape error messages in the dash app - Check request size in chunked transfers - Add authorization checks to the version endpoint - Escape SQL LIKE queries
- Fix cargo-deny CI: use command-arguments instead of arguments for --config flag - Fix list_group_members to return NotFoundErrorResponse instead of DefaultErrorResponse - Log body-read errors in chunked transfer handler - Add unit tests for escape_like_pattern helper Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The previous config grouped all Rust dependencies into a single PR, which caused build failures from incompatible major version bumps. Now patch and minor updates are grouped separately, and major version bumps get individual PRs for easier review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds workflow import/export support to torc-dash (UI + backend CLI bridge), and fixes imported results not appearing in the default torc results list view by ensuring workflow_result is populated on result creation.
Changes:
- Add import/export modals and UI actions in torc-dash, backed by new
/api/cli/exportand/api/cli/importendpoints. - Extend workflow export format to include
compute_nodeswhen exporting results, and update import to remap/placeholder compute nodes so results can round-trip. - Fix results visibility after import by upserting
workflow_resultrecords oncreate_result; adjust Dependabot grouping behavior.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| torc-dash/static/js/app.js | Initializes new import/export modal setup in dashboard startup. |
| torc-dash/static/js/app-workflows.js | Adds export/import execution logic and import modal opening behavior. |
| torc-dash/static/js/app-modals.js | Implements export/import modal wiring, tab switching, and file upload handling. |
| torc-dash/static/js/app-details.js | Adds “Export” button behavior and default output filename generation. |
| torc-dash/static/js/api.js | Adds client helpers for /api/cli/export and /api/cli/import. |
| torc-dash/static/index.html | Adds Import button and new Import/Export modals to the UI. |
| tests/test_workflow_export.rs | Adds/extends tests for exporting/importing results + compute nodes and backward compatibility. |
| src/server/api/results.rs | Fixes results listing behavior by inserting/updating workflow_result on result creation. |
| src/client/commands/workflows.rs | Exports compute nodes with results; imports compute nodes + placeholder fallback; prints enhanced import summary. |
| src/client/commands/workflow_export.rs | Extends export document + ID mappings/stats to include compute nodes. |
| src/bin/torc-dash.rs | Adds new HTTP endpoints to run torc workflows export/import from the dashboard. |
| .github/dependabot.yml | Adjusts Dependabot grouping/limits to reduce noisy PR behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR also
torc results list