Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a "Sync Status" button to the torc-dash web interface that allows users to detect and handle orphaned running jobs whose Slurm allocations have ended unexpectedly. The feature provides a GUI interface for the existing torc workflows sync-status CLI command, making it more accessible to users.
Changes:
- Added a new "Sync Status" button to the Recovery section of the workflow details panel
- Implemented a modal dialog that shows orphaned job analysis with dry-run preview and confirmation workflow
- Created a new backend API endpoint
/api/cli/sync-statusto invoke the CLI command - Updated CLI command documentation to improve clarity and removed the
hideflag to make it visible in help output
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| torc-dash/static/index.html | Added sync status button in Recovery section and sync-status modal dialog structure |
| torc-dash/static/css/style.css | Added btn-info styles for the new info-colored button |
| torc-dash/static/js/app.js | Added setupSyncStatusModal() call to initialize the modal |
| torc-dash/static/js/app-modals.js | Implemented setupSyncStatusModal() with event handlers following existing patterns |
| torc-dash/static/js/app-workflows.js | Implemented syncStatus() and executeSyncStatus() functions to handle the workflow |
| torc-dash/static/js/app-details.js | Added click event handler for the sync status button |
| src/bin/torc-dash.rs | Added SyncStatusRequest struct and cli_sync_status_handler API endpoint |
| src/client/commands/workflows.rs | Updated sync-status command documentation and removed hide flag to make it visible |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.