Restore bulk_jobs body limit in live router#248
Merged
Conversation
Reapply the large request-body limit to /bulk_jobs in the Axum\nrouter while leaving default limits in place for the rest of\nthe API.\n\nAdd router tests covering both the large bulk-jobs request path\nand the default-limit behavior on a non-bulk JSON endpoint.
Collaborator
Author
|
This fix works now on Perlmutter. I am able to submit my jobs and have it do it in 10k batches. There is another issue I'll open about the GPUs. I still don't think they are working correctly. |
daniel-thom
requested changes
Apr 6, 2026
Collaborator
daniel-thom
left a comment
daniel-thom
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing the bug.
Rename the bulk upload body-limit helper and constant so their scope is explicit in the live router. Document the Axum 2 MiB default and the TORC_MAX_REQUEST_BODY_MB override in the server docs so PR feedback is resolved without changing route behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the larger request-body limit for
/torc-service/v1/bulk_jobsin the Axum live router.
This fixes a regression where
torc submitcould fail on largeparameterized workflows with:
413 Failed to buffer the request body: length limit exceededThe change applies the larger body limit only to
/bulk_jobs, whileleaving the default Axum body limit in place for other routes.
Changes
/bulk_jobs-specific request body limit insrc/server/live_router.rsTORC_MAX_REQUEST_BODY_MB/bulk_jobsVerification
cargo fmt -- --checkdprint checkDATABASE_URL=sqlite:db/sqlite/dev.db cargo clippy --all --all-targets --all-features -- -D warningsSQLX_OFFLINE=true cargo test bulk_jobs_route_accepts_body_larger_than_default_limit --features openapi-codegenSQLX_OFFLINE=true cargo test non_bulk_json_route_still_uses_default_body_limit --features openapi-codegen