Allow bzip2-1.0.6 license for plotly_kaleido build dep chain#312
Merged
daniel-thom merged 1 commit intomainfrom May 10, 2026
Merged
Allow bzip2-1.0.6 license for plotly_kaleido build dep chain#312daniel-thom merged 1 commit intomainfrom
daniel-thom merged 1 commit intomainfrom
Conversation
The plotly 0.14 → plotly_kaleido 0.13 → zip 7 → bzip2 → libbz2-rs-sys chain pulled in a crate licensed bzip2-1.0.6, which is a permissive SPDX-listed FOSS license (BSD-like with a non-endorsement clause). It appears only as a build-dep of plotly_kaleido (used by build.rs to extract the kaleido binary), so it doesn't land in the compiled torc binary -- but cargo-deny still requires it to be on the allow-list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Security workflow's
cargo-denylicense check that broke after #311 merged. The plotly 0.14 → plotly_kaleido 0.13 → zip 7 → bzip2 →libbz2-rs-syschain pulled in a crate licensedbzip2-1.0.6, which wasn't on the allow-list.Why this is safe
bzip2-1.0.6is a permissive SPDX-listed FOSS license (BSD-like with a non-endorsement clause), used by the original bzip2 C library and now bylibbz2-rs-sys(a Rust port).build.rs— used at build time to extract the kaleido binary — so it doesn't land in the compiledtorcbinary.Failing run for context: https://github.com/NatLabRockies/torc/actions/runs/25619601153
Test plan
cargo deny check(runs in CI)🤖 Generated with Claude Code