Conversation
Wrap iframe embeds in a .video-embed div for reliable 16:9 rendering, add responsive CSS to all HTML templates, and set the WebView base URL to the iframe's host so embedded providers can load their resources. https://claude.ai/code/session_01KfcuMiGfVnvJu14WGLK6yR
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances video content handling by adding responsive video embed styling across all HTML templates and improving how iframe base URLs are extracted for proper content loading.
Key Changes
Added responsive video embed CSS to all three HTML templates (dark, light, sepia):
.video-embedclass using padding-bottom technique for 16:9 aspect ratioImproved iframe base URL extraction in BookmarkDetailScreen:
extractEmbedBaseUrl()function that parses iframe src attributes using regexEnhanced video embed HTML wrapping in BookmarkDetailViewModel:
.video-embeddiv containerImplementation Details
extractEmbedBaseUrl()function uses regex to find iframe src attributes andUri.parse()for safe URL parsingpadding-top: 56.25%to maintain 16:9 aspect ratio without knowing video dimensionshttps://claude.ai/code/session_01KfcuMiGfVnvJu14WGLK6yR