Fix log file size limit calculation in MyDeckApplication#49
Merged
NateEaton merged 1 commit intocodex/review-spec-for-reading-progress-savingfrom Feb 10, 2026
Conversation
Treessence's sizeLimit parameter is in bytes, not kilobytes. Setting sizeLimit=128 created 128-byte files, causing immediate rotation after 1-2 log lines. This left file 0 empty and files 1/2 with only a couple of entries each. Changed to 128*1024 (131072 bytes = 128 KB) as originally intended by the spec. https://claude.ai/code/session_01LbMyTbouPGq999Br8XVuEZ
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
NateEaton
merged commit beb77a4
into
codex/review-spec-for-reading-progress-saving
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the log file size limit configuration to correctly specify 128 KB instead of 128 bytes by converting the value to bytes and adding clarifying comments.
Changes
sizeLimitfrom128to128 * 1024in two logging configurations (debug and release builds)Details
The original code set
sizeLimit = 128, which was interpreted as 128 bytes - far too small for practical logging. The fix multiplies by 1024 to convert to the intended 128 KB limit, making log rotation behavior more reasonable and preventing excessive file churn.https://claude.ai/code/session_01LbMyTbouPGq999Br8XVuEZ