Claude/fix reading bookmark issues mnn zc#8
Merged
Conversation
Two documents: 1. Reading progress fix spec - identifies root cause (0% progress not saved, coroutine cancellation on exit) and proposes 4 targeted changes 2. Bookmark creation research - compares Eckard, ReadeckApp, and readeck_related_app approaches; recommends Eckard's polling pattern https://claude.ai/code/session_01Jhx8sq3d7Rb77BcGGB7spw
Incorporates user feedback: - Keep the > 0 guard (matches native behavior) - Remove premature progress=1 on article open (Bug B) - Add completion lock (isReadLocked) per native Readeck rules - Fix onCleared() coroutine cancellation with independent scope - Add behavior matrix and updated testing plan https://claude.ai/code/session_01Jhx8sq3d7Rb77BcGGB7spw
From Google AI Studio
…strategy - Identifies sub-second timestamp precision as cause of sync 500 errors (confirmed in both MyDeck and Eckard clients) - Documents empty payload guard for POST /bookmarks/sync - Proposes three-phase incremental bookmark ingestion: Phase 1: Insert metadata immediately after creation Phase 2: Background poll until server extraction completes Phase 3: On-demand or automatic content download - Includes download icon UI concept and revised createBookmark() implementation https://claude.ai/code/session_01Jhx8sq3d7Rb77BcGGB7spw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document solutions to two issues, new bookmark adding and reading progress tracking