Skip to content

Update README.md#23

Merged
SRWieZ merged 2 commits intoNativePHP:mainfrom
marcanthonysurmont:patch-1
Feb 17, 2025
Merged

Update README.md#23
SRWieZ merged 2 commits intoNativePHP:mainfrom
marcanthonysurmont:patch-1

Conversation

@marcanthonysurmont
Copy link
Copy Markdown
Contributor

No description provided.

@PeteBishwhip PeteBishwhip self-requested a review February 14, 2025 11:37
Copy link
Copy Markdown
Member

@PeteBishwhip PeteBishwhip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcanthonysurmont!

I know I've given your tool a try and it's great. Before we approve this for inclusion, do you think you could add a README to your repo, explaining the project and how to use it? This is a good practice and will ensure anyone who clicks through knows how to use your project.

@marcanthonysurmont
Copy link
Copy Markdown
Contributor Author

Hey @PeteBishwhip , I added the README. Hopefully is it's good

@PeteBishwhip
Copy link
Copy Markdown
Member

Brilliant! Thanks for that. Now all we need is for it to be placed in its alphabetical place, rather than the bottom of the file.

If you're happy to do that, great. If you prefer I drop a commit to change its location, happy to help. Just let me know. :).

Once that's done, I think this will be good to go!

Copy link
Copy Markdown
Member

@PeteBishwhip PeteBishwhip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requires placing in alphabetical order. Readme looks good.

@PeteBishwhip PeteBishwhip requested a review from a team February 16, 2025 17:44
@SRWieZ SRWieZ merged commit 41df49d into NativePHP:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants