Update electron dependencies #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by a type declaration conflict between `@types/node` and `electron`. Electron bundles its own Node.js types that sometimes conflict with the standalone @types/node package. The best solution is to add skipLibCheck: true to the TypeScript compiler options
SRWieZ
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the npm packages. We're back at 0 vulnerabilities 🎉
There was a type declaration conflict between
@types/nodeandelectron. Electron bundles its own Node.js types that sometimes conflict with the standalone@types/nodepackage.I added skipLibCheck: true to the TypeScript compiler options. Apparently that's a common fix in Electron land
Another approach would be to lock
@types/nodedown to a version where the types did not conflict. But I like the current fix because the conflict itself seems superficial.Thoughts appreciated!