fix(ios): pass log message as NSLog argument, not format string#108
Open
bkuhl wants to merge 1 commit intoNativePHP:mainfrom
Open
fix(ios): pass log message as NSLog argument, not format string#108bkuhl wants to merge 1 commit intoNativePHP:mainfrom
bkuhl wants to merge 1 commit intoNativePHP:mainfrom
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PHPSchemeHandler.getResponse(request:completion:)interpolates the request URI directly intoNSLog's first argument:NSLog's first argument is aprintf-style format string. Swift string interpolation embeds the URI into that format string verbatim, so any%in the URI is parsed as a format specifier. When the URI contains%XXpercent-encoded sequences (the normal case for any path with reserved characters orrawurlencoded data),NSLogreadsva_argsthat don't exist and dereferences garbage memory.Result:
EXC_BAD_ACCESS (SIGSEGV)on thecom.nativephp.persistent-phpqueue. Reproducible whenever a request's URI contains%. Stack trace top frames:Fix
Use
NSLog's two-argument form so the message is an argument to%@, not part of the format string. Two-line change to lines 595 and 609:Identical log output, no crash. Same pattern any printf-style API expects: format string is a constant; data goes through arguments.
Test plan
%XXsequences (real-world rawurlencode'd token)%(the only ones that didn't crash before) still log correctly