Fix free plugin claim expiry date to match extended offer#271
Merged
Fix free plugin claim expiry date to match extended offer#271
Conversation
The claimFreePlugins controller action still had the old Feb 28 expiry while shouldSeeFreePluginsOffer had already been updated to May 31. This caused users to see the offer banner but get "expired" when claiming. Also adds tests covering the claim flow and expiry boundaries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use mb_strcut() instead of substr() to avoid cutting multi-byte UTF-8 characters (em dashes, emoji, etc.) in half when extracting search snippets, which caused JSON encoding failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claimFreePluginscontroller action had a hardcoded expiry of2026-02-28whileshouldSeeFreePluginsOffer(which controls the banner) had already been updated to2026-05-312026-05-31 23:59:59to match the extended offer periodTest plan
test_eligible_user_can_claim_free_plugins— verifies claims work during the offer periodtest_claim_is_rejected_after_offer_expires— verifies expiry after May 31test_claim_is_allowed_on_last_day_of_offer— boundary test on May 31test_ineligible_user_cannot_claim_free_plugins— no recent license/subscriptiontest_user_cannot_claim_plugins_twice— already claimed all plugins🤖 Generated with Claude Code