Queue new plugin notifications via a dedicated job#356
Merged
Conversation
Move the notification fan-out from Plugin::approve() into a SendNewPluginNotifications job so the admin UI isn't blocked iterating through every opted-in user during approval. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewPluginAvailablenotification fan-out fromPlugin::approve()into a newSendNewPluginNotificationsqueued jobChanges
app/Jobs/SendNewPluginNotifications.php— queued job that queries opted-in users and sendsNewPluginAvailablenotificationsPlugin::approve()— dispatches the job instead of inlineNotification::send()NewPluginAvailableTest— integration tests now assert the job is dispatched viaBus::fake()SendNewPluginNotificationsTest— dedicated tests for the job's notification logicTest plan
🤖 Generated with Claude Code