Skip to content

fix(android): enable edge-to-edge only for fullscreen modals#11140

Merged
NathanWalker merged 1 commit intoNativeScript:mainfrom
felixkrautschuk:fix-android-modal-ete
Mar 18, 2026
Merged

fix(android): enable edge-to-edge only for fullscreen modals#11140
NathanWalker merged 1 commit intoNativeScript:mainfrom
felixkrautschuk:fix-android-modal-ete

Conversation

@felixkrautschuk
Copy link
Contributor

@felixkrautschuk felixkrautschuk commented Mar 17, 2026

PR Checklist

What is the current behavior?

Edge-to-edge is getting enabled for all modals, which is causing layout issues on non-fullscreen modals on Android.

What is the new behavior?

Edge-to-edge is getting enabled only for fullscreen-modals to prevent layout issues for non-fullscreen modals on Android.

Fixes/Implements/Closes #11139.

@nx-cloud
Copy link

nx-cloud bot commented Mar 17, 2026

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 5906033

Command Status Duration Result
nx test apps-automated -c=ios ❌ Failed 3m 1s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-17 15:30:21 UTC

@CatchABus
Copy link
Contributor

Looks good to me, nice catch!

@NathanWalker NathanWalker merged commit b74035f into NativeScript:main Mar 18, 2026
3 of 4 checks passed
@felixkrautschuk felixkrautschuk deleted the fix-android-modal-ete branch March 19, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android non-fullscreen modal layout issues

3 participants