Elements tab support for iOS Chrome DevTools#4930
Merged
Conversation
ghost
assigned
…droid patch elements dom-node tests to test for ios too
petekanev
force-pushed
the
pete/elements-ios
branch
from
5c71dd3 to
adaf9aa
Compare
petekanev
force-pushed
the
pete/elements-ios
branch
from
73904a6 to
1aae391
Compare
petekanev
requested review from
PanayotCankov,
hshristov,
tdermendjiev and
vakrilov
petekanev
changed the title
Contributor
Author
|
run ci |
2 similar comments
Contributor
Author
|
run ci |
Contributor
|
run ci |
vakrilov
approved these changes
Oct 12, 2017
| result.push([prop, style[prop]]); | ||
| } | ||
|
|
||
| result.push(["top", "auto"]); |
Contributor
There was a problem hiding this comment.
Add a comment why these are needed
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in the PR aim to provide implementation for the DOM and CSS agents in the Chrome Devtools Inspector protocol for iOS.
The implementation steps on top of what was already established in the tns-core-modules to build
dom-nodeobjects on demand when the Inspector is attached. Thanks to that, no changes to the core modules have been done, but rather only in thedebuggermodule.The commit message references a specific issue in this repo
Implements NativeScript/ios-jsc#791
You have unit tests
Tried to accommodate the
dom-node-teststo work with the iOS implementation of the DevTools Inspector.