Skip to content

refactor: simplify SimDeck service lifecycle#64

Merged
DjDeveloperr merged 13 commits into
mainfrom
codex/simplify-service-lifecycle
May 25, 2026
Merged

refactor: simplify SimDeck service lifecycle#64
DjDeveloperr merged 13 commits into
mainfrom
codex/simplify-service-lifecycle

Conversation

@DjDeveloperr
Copy link
Copy Markdown
Collaborator

Summary

  • Replace the old workspace/project daemon flow with a single reusable SimDeck service lifecycle.
  • Make bare simdeck the primary UI entrypoint, with -p/--port, -a/--autostart, and --open documented in help.
  • Hard-error removed simdeck ui and simdeck serve commands.
  • Add long-running stream and accessibility metrics, reset the stream pipeline after the last subscriber disconnects, and preserve Android SDK environment for LaunchAgent services.
  • Simplify docs and skills/simdeck/SKILL.md for the new service model.

Validation

  • npm run format
  • cargo test --manifest-path packages/server/Cargo.toml
  • npm run --prefix packages/client test
  • npm run test:github-actions
  • npm run test:integration-harness
  • cargo clippy --manifest-path packages/server/Cargo.toml --all-targets -- -D warnings
  • npm run docs:build
  • npm run format:check
  • npm pack --dry-run
  • git diff --check

Manual smoke

  • Exercised service lifecycle, iOS device commands, fixture install/launch/uninstall, selector actions, gestures, screenshots, recording, raw stream, stats/logs/sample, batch, and Maestro.
  • Exercised Android AVD boot/list/describe/screenshot/tap/shutdown under the LaunchAgent service.
  • Verified Chrome WebRTC stream connects, frame counters advance over 30 seconds, packet loss stays at 0, and closing the tab drops active streams to 0 with a stream pipeline reset.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fe014191-d442-4d52-bfff-4a73791f0970

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/simplify-service-lifecycle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DjDeveloperr DjDeveloperr marked this pull request as ready for review May 25, 2026 13:58
@DjDeveloperr DjDeveloperr force-pushed the codex/simplify-service-lifecycle branch from e290898 to 757820f Compare May 25, 2026 14:18
@DjDeveloperr DjDeveloperr merged commit 877dfc9 into main May 25, 2026
9 checks passed
@DjDeveloperr DjDeveloperr deleted the codex/simplify-service-lifecycle branch May 25, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant