Skip to content

fix: sign SimDeck release with existing team ID#71

Merged
DjDeveloperr merged 1 commit into
mainfrom
fix-macos-binary-signing
May 31, 2026
Merged

fix: sign SimDeck release with existing team ID#71
DjDeveloperr merged 1 commit into
mainfrom
fix-macos-binary-signing

Conversation

@DjDeveloperr
Copy link
Copy Markdown
Collaborator

Summary

  • Use the existing APPLE_TEAM_ID environment variable to select the Developer ID signing identity in the release workflow.
  • Fail non-dry-run releases when the required Apple signing/notary secrets are missing.
  • Prevent npm publish from rerunning scripts and overwriting the signed binary.

Testing

  • npm run test:github-actions

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a71648a0-1685-4185-a3e3-15fdf7f2bb1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-macos-binary-signing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DjDeveloperr DjDeveloperr merged commit ed87fb8 into main May 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant