Fix handling of user implemented interfaces#1239
Merged
Conversation
Contributor
Author
|
test ngapps_android api23 |
vmutafov
force-pushed
the
vmutafov/sbg-interfaces-handling-fix
branch
from
91b3ea9 to
e86e998
Compare
vmutafov
force-pushed
the
vmutafov/sbg-interfaces-handling-fix
branch
from
e86e998 to
b70d8e9
Compare
Contributor
Author
|
test ngapps_android api23 |
vtrifonov
approved these changes
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the provided list of interfaces implemented by the user when extending a native class was set directly to a JavaClass instance of the extended native class. This, however, results in permanent storing those interfaces in the JavaClass and sometimes there is a wrongly generated function binding with a name coming from a previously used interface elsewhere in the app.