Fix cyclic dependency and throw error if missing metadata folder#1470
Merged
Fix cyclic dependency and throw error if missing metadata folder#1470
Conversation
… error if missing metadata folder
darind
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #1471
Related to: #1382
Currently, if the
metadatafolder is missing there is no exception thrown. When checking the behavior around the metadata files reading, a cyclic dependency was found if aNativeScriptExceptionis thrown early in the runtime initialization phase. The dependency occurs when trying to get anObjectManagerinstance and if no object manager is found an exception is thrown. This results in a cycle of crashes. There is a workaround as the object manager is not needed in every case of throwing an exception but only when theNativeScriptExceptioncontains a nested JS or Java exception.After this fix, an exception was added in case the metadata folder is missing.